-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up latest knative.dev/pkg, pipelines, and k8s 0.22 libs #1293
Conversation
cc @dibyom |
// All of the top-level functions that take an `error` are built to be able | ||
// to take any error, not just wrapped errors. This allows you to use errwrap | ||
// without having to type-check and type-cast everywhere. | ||
package errwrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the source files in the third_party folder? Shouldn't they be in vendor/ (with only the LICENSE file in third_party?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are put here by go-licenses as part of compliance with whichever license the software uses. Some require dedistributing source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah got it. thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
This picks up the changes to
knative.dev/pkg
to utilize the K8s 0.22 libraries.This also let's us drop the apimachinery patch we've been carrying.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes