-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate API reference docs for Triggers #1298
Conversation
/assign @dibyom |
/retest |
1 similar comment
/retest |
@@ -0,0 +1,48 @@ | |||
{{ define "members" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have this in pipelines as well, it would be nice to have this in plumbing and vendor it from there instead of having to do this is each Tekton sub project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This will add `hack/update-reference-docs.sh` to `hack/update-codegen.sh`, resulting in `docs/triggers-api.md` being generated. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
c748331
to
912df6d
Compare
@dibyom I had to rebase and re-run |
/lgtm |
Changes
This will add
hack/update-reference-docs.sh
tohack/update-codegen.sh
, resulting indocs/triggers-api.md
being generated.There probably needs to be a followup in the website repo to actually do something with the reference doc too. =)
/kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes