Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for ClusterInteceptor, CTB, EL, TT and TB count #1305

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Add metrics for ClusterInteceptor, CTB, EL, TT and TB count #1305

merged 1 commit into from
Feb 21, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 7, 2022 •
edited
Loading

Adding metrics for counting EL, TT, CTB, ClusterInteceptor and TB.
Fixes #1294

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Add Metrics for ClusterInteceptor, eventlistener, triggertemplate, clustertriggerbinding and triggerbinding count.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 7, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 7, 2022
@khrm
Copy link
Contributor Author

khrm commented Feb 7, 2022

I will change this to injection based.

@khrm khrm force-pushed the metrics branch 6 times, most recently from e593bc6 to a3befee Compare February 8, 2022 14:31
@khrm khrm changed the title WIP: Add metrics for ClusterInteceptor, EL, TT and TB count Add metrics for ClusterInteceptor, EL, TT and TB count Feb 8, 2022
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 53.2%

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 53.2%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 53.2%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 53.2%

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 9, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 50.0%

@khrm khrm changed the title Add metrics for ClusterInteceptor, EL, TT and TB count Add metrics for ClusterInteceptor, CTB, EL, TT and TB count Feb 9, 2022
@khrm khrm added this to the Triggers v0.19 milestone Feb 9, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 32.6%

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 76.6%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 76.6%

@savitaashture savitaashture mentioned this pull request Feb 16, 2022
Closed
savitaashture
savitaashture reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

docs/metrics.md Show resolved Hide resolved
dibyom
dibyom reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Some minor spelling issues!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2022
@khrm
Copy link
Contributor Author

khrm commented Feb 21, 2022

/test pull-tekton-triggers-build-tests

@khrm
Copy link
Contributor Author

khrm commented Feb 21, 2022

/test tekton-triggers-unit-tests

/test pull-tekton-triggers-integration-tests

@khrm
Add metrics for ClusterInteceptor, CTB, EL, TT and TB count
8a19d50 
Adding metrics for counting EL, TT, CTB, clusterinteceptor and TB.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go Do not exist 45.5%
pkg/reconciler/metrics/metrics.go Do not exist 76.6%

savitaashture
savitaashture approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉 👍 🎉

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@tekton-robot tekton-robot merged commit 749189b into tektoncd:main Feb 21, 2022
@khrm khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2022
@khrm khrm deleted the metrics branch February 28, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@savitaashture savitaashture savitaashture approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@dibyom dibyom

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.19
Development

Successfully merging this pull request may close these issues.

Metrics at Triggers Controller Level
4 participants
@khrm @tekton-robot @dibyom @savitaashture