Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Follow naming conventions for resourceTemplates" #1693

Merged

Conversation

savitaashture
Copy link
Contributor

This reverts commit 447f613.

Reason:

Reverting this PR because altering the tag will impact the upgrade flow. The existing TriggerTemplate data with the old tag still persists in etcd. Consequently, during an upgrade with the new tag, the data isn't fetched for the trigger template as expected.

We'll revert this PR for now and reintroduce the change when we support the new ApiVersion. At that point, we'll utilize conversion functionality (convertTo and convertFrom) to ensure seamless transition. By incorporating the ApiVersion, we'll be able to adjust the tag accordingly.

Fixes: #1690

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2024
@savitaashture savitaashture added this to the Triggers v0.26.1 milestone Feb 8, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

Please write in release note also.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 8, 2024
@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

Also, update the release and mention this in Release of v0.26.0

@dibyom
Copy link
Member

dibyom commented Feb 8, 2024

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@tekton-robot tekton-robot merged commit f6f77f4 into tektoncd:main Feb 8, 2024
6 checks passed
@savitaashture
Copy link
Contributor Author

/cherry-pick release-v0.26.x

@tekton-robot
Copy link

@savitaashture: new pull request created: #1694

In response to this:

/cherry-pick release-v0.26.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@savitaashture
Copy link
Contributor Author

Also, update the release and mention this in Release of v0.26.0

@khrm i have updated https://github.com/tektoncd/triggers/releases/tag/v0.26.0 PTAL

@savitaashture savitaashture removed this from the Triggers v0.26.1 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functionality is not working after upgrading Triggers from 0.25.x to 0.26.0
4 participants