-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Follow naming conventions for resourceTemplates" #1693
Revert "Follow naming conventions for resourceTemplates" #1693
Conversation
This reverts commit 447f613.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Please write in release note also. /kind bug |
Also, update the release and mention this in Release of v0.26.0 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-v0.26.x |
@savitaashture: new pull request created: #1694 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@khrm i have updated https://github.com/tektoncd/triggers/releases/tag/v0.26.0 PTAL |
This reverts commit 447f613.
Reason:
Reverting this PR because altering the tag will impact the upgrade flow. The existing TriggerTemplate data with the old tag still persists in etcd. Consequently, during an upgrade with the new tag, the data isn't fetched for the trigger template as expected.
We'll revert this PR for now and reintroduce the change when we support the new ApiVersion. At that point, we'll utilize conversion functionality (convertTo and convertFrom) to ensure seamless transition. By incorporating the ApiVersion, we'll be able to adjust the tag accordingly.
Fixes: #1690
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes