-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update securityContext to include required configurations when the flag el-security-context is enabled #1736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind feature
10200c6
to
0711afe
Compare
0711afe
to
d8885b3
Compare
d8885b3
to
9a451c0
Compare
The following is the coverage report on the affected files.
|
9a451c0
to
1aff542
Compare
The following is the coverage report on the affected files.
|
1aff542
to
7c5c79f
Compare
The following is the coverage report on the affected files.
|
One nit and looks like we need to fix the yaml files. Otherwise, LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…runAsUser and runAsGroup As part of this PR, when the flag el-security-context is enabled the securityContext have all configuration except RunAsUser and RunAsGroup Added new fields default-run-as-user and default-run-as-group to config-defaults-triggers configmap so that RunAsUser and RunAsGroup can be now configured through CM This change handles cases in environments where user ID 65532 is not allowed, such as OpenShift. Signed-off-by: Savita Ashture <sashture@redhat.com>
7c5c79f
to
cf79605
Compare
The following is the coverage report on the affected files.
|
@khrm PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As part of this PR, when the flag
el-security-context
is enabled the securityContext have all configurationexcept RunAsUser and RunAsGroup
Added new fields
default-run-as-user
anddefault-run-as-group
toconfig-defaults-triggers
configmap so that RunAsUser and RunAsGroup can be now configured through CMThis change handles cases in environments where user ID 65532 is not allowed, such as OpenShift.
Signed-off-by: Savita Ashture sashture@redhat.com
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes