Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tekton instead of all as categories 🎿 #360

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

vdemeester
Copy link
Member

Changes

This means Tekton struct won't show in kubectl get all but in
kubectl get tekton 😉.

This is the same change as tektoncd/pipeline#1884 for triggers 👼

/cc @dibyom @wlynch

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Remove the category `all` for our CRD and have a `tekton` categorie that is shared with other tektoncd projects

This means Tekton struct won't show in `kubectl get all` but in
`kubectl get tekton` 😉.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
/lgtm

@dibyom
Copy link
Member

dibyom commented Jan 29, 2020

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@vdemeester
Copy link
Member Author

/test pull-tekton-triggers-build-tests

@tekton-robot tekton-robot merged commit 02b5790 into tektoncd:master Jan 29, 2020
@vdemeester vdemeester deleted the crd-categories branch January 29, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants