Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tektoncd-pipeline to 0.10.1 #396

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jan 29, 2020

Changes

This will bump the tektoncd-pipeline dep to 0.10.1

Now use pipelineresources from resourceclientset

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2020
@piyush-garg piyush-garg changed the title Bump tektoncd-pipeline to 0.10.0 Bump tektoncd-pipeline to 0.10.0 and update lint config Jan 29, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

That's a funny side effect that it uses v1alpha2 struct in the deepcopy generated files, because of the type aliasing 🙃

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@piyush-garg piyush-garg changed the title Bump tektoncd-pipeline to 0.10.0 and update lint config Bump tektoncd-pipeline to 0.10.0 Jan 29, 2020
@piyush-garg piyush-garg changed the title Bump tektoncd-pipeline to 0.10.0 Bump tektoncd-pipeline to 0.10.1 Jan 30, 2020
This will bump the tektoncd-pipeline dep to 0.10.1

Now use pipelineresources from resourceclientset
@chmouel
Copy link
Member

chmouel commented Jan 30, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@@ -87,6 +87,7 @@ func main() {
DynamicClient: dynamicCS,
TriggersClient: sinkClients.TriggersClient,
PipelineClient: sinkClients.PipelineClient,
ResourceClient: sinkClients.ResourceClient,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting......

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@tekton-robot tekton-robot merged commit 68f5713 into tektoncd:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants