Add CEL function canonical. #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
dibyom
approved these changes
Feb 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
bigkevmcd
force-pushed
the
add-canonical-lookup
branch
3 times, most recently
from
0c0acf1
to
42ff38d
Compare
This adds an overlay function for CEL expressions, that accepts a header name and does a canonical lookup on the value, returning a string.
bigkevmcd
force-pushed
the
add-canonical-lookup
branch
from
42ff38d
to
b0aceb1
Compare
tekton-robot
added
size/L
|
LGTM! What do you think @ncskier - header.Canonical as a replacement for header.matches? |
|
Yep, I think that would be great; thanks Kevin! |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds an overlay function for CEL expressions, that accepts a header
name and does a canonical lookup on the value, returning a string.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes