-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inaccurate docs about TriggerTemplate #477
Conversation
@ncskier: GitHub didn't allow me to request PR reviews from the following users: disposab1e. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-tekton-triggers-build-tests |
Perhaps you mights change in the /README.md too?
|
Thanks @disposab1e, the README was not adequately updated when Triggers disallowed the creation of any K8s resource 🤦♂ I just updated my PR to fix this. |
- Fix inaccurate main README which said "TriggerTemplates can create any Kubernetes resource." - Make it more visible that TriggerTemplates can only create Tekton resources.
/test pull-tekton-triggers-build-tests |
1 similar comment
/test pull-tekton-triggers-build-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Issue #476 was raised because our docs have inaccurate information about what K8s resources TriggerTemplates can create.
/cc @disposab1e
/cc @dibyom
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.