Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL parsing to CEL expressions. #591

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

bigkevmcd
Copy link
Member

@bigkevmcd bigkevmcd commented Jun 2, 2020

Changes

This adds a new function parseURL to the CEL expression library.

This will act on a string, and parse it into a map which can be accessed from the remainder of the expression.

For example, 'https://example.com/testing#test'.parseURL().fragment == 'test'

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

Add URL parsing to CEL expressions.
    
This adds a new function `parseURL` to the CEL expression library.
    
This will act on a string, and parse it into a map which can be accessed from the remainder of the expression.
    
For example, 'https://example.com/testing#test'.parseURL().fragment == 'test'

This addresses #590

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 87.1% 87.2% 0.1
pkg/template/cel/cel.go Do not exist 76.3%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 87.1% 87.2% 0.1

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 87.1% 87.2% 0.1

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 87.1% 87.2% 0.1

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny typo. Otherwise LGTM!

<tr><td>queryStrings</td><td>{"s": ["testing"]}</td></tr>
<tr><td>auth</td><td>{"username": "user", "password": "pass"}</td></tr>
</table>
Note the difference between <b>query</b> and <b>queryStrings></b>, in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: extra > here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
This adds a new function `parseURL` to the CEL expression library.

This will act on a string, and parse it into a map which can be accessed from the remainder of the expression.

For example, 'https://example.com/testing#test'.parseURL().fragment == 'test'
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 87.1% 87.2% 0.1

@dibyom
Copy link
Member

dibyom commented Jun 2, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@tekton-robot tekton-robot merged commit 7ae07c1 into tektoncd:master Jun 2, 2020
@bigkevmcd bigkevmcd deleted the cel-url-parsing branch June 4, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants