-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL parsing to CEL expressions. #591
Conversation
The following is the coverage report on the affected files.
|
0b113d9
to
aa941ac
Compare
The following is the coverage report on the affected files.
|
aa941ac
to
7416626
Compare
The following is the coverage report on the affected files.
|
7416626
to
ac13ef1
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny typo. Otherwise LGTM!
docs/cel_expressions.md
Outdated
<tr><td>queryStrings</td><td>{"s": ["testing"]}</td></tr> | ||
<tr><td>auth</td><td>{"username": "user", "password": "pass"}</td></tr> | ||
</table> | ||
Note the difference between <b>query</b> and <b>queryStrings></b>, in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: extra > here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a new function `parseURL` to the CEL expression library. This will act on a string, and parse it into a map which can be accessed from the remainder of the expression. For example, 'https://example.com/testing#test'.parseURL().fragment == 'test'
ac13ef1
to
20ac551
Compare
The following is the coverage report on the affected files.
|
/lgtm |
Changes
This adds a new function
parseURL
to the CEL expression library.This will act on a string, and parse it into a map which can be accessed from the remainder of the expression.
For example,
'https://example.com/testing#test'.parseURL().fragment == 'test'
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes
This addresses #590