Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of version in config #623

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jun 19, 2020

Standardised formatting of release version to have double quotes.
Not having quotes causes sed expression to fail to detect them.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2020
@khrm khrm changed the title Fix formatting of release version Fix formatting of version in config Jun 19, 2020
Standardised formatting of release version to have double quotes.
Not having quotes causes sed expression to fail to detect them.
@dibyom
Copy link
Member

dibyom commented Jun 19, 2020

/kind bug
/approve
/lgtm

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Jun 19, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@tekton-robot tekton-robot merged commit 190199b into tektoncd:master Jun 19, 2020
@khrm khrm deleted the fix/Formatting branch July 28, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants