-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interceptor to processTriggerSpec, update readHTTP and trigger function #695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to clean up any commented out code!
I think mistakenly you have checked in a binary triggerRun as part of the PR Please remove that |
I think we should follow the naming convention for directory name here for |
yeah I agree |
e03fcc8
to
a6442dc
Compare
1064c54
to
356924d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the build tests:
/home/prow/go/src/github.com/tektoncd/triggers is out of date. Please run hack/update-codegen.sh
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@@ -20,7 +20,8 @@ import ( | |||
"fmt" | |||
"os" | |||
|
|||
"github.com/tektoncd/triggers/cmd/triggerRun/cmd" | |||
"github.com/tektoncd/triggers/cmd/triggerrun/cmd" | |||
_ "k8s.io/client-go/plugin/pkg/client/auth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ "k8s.io/client-go/plugin/pkg/client/auth" | |
Can we remove this import as its not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually need this one. Its contains auth plugins needed to setup the kubeclients for various k8s providers. See https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L33
It is an interesting pattern, I'll admit 😛
The following is the coverage report on the affected files.
|
Let's also squash up the commits :) |
2087501
to
5f3da07
Compare
The following is the coverage report on the affected files.
|
…esources and trigger function to run Trigger CLI
5f3da07
to
afc6231
Compare
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…esources and trigger function to run Trigger CLI
Changes
This PR is a part of creating CLI for TriggerRun. It contains the parts that add interceptor to processTriggerSpec, updates readHTTP to print out resources and trigger function to run Trigger CLI.
(Related to issue #624. )
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes