Updates to the happy path readme(s) #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
|
Thanks @jjasghar @a-roberts Once the nits are addressed, this is good to go! |
|
Can you squash the commits into one? |
* Adam and I spent the 4th cd.foudation twitch stream making edits to the readme(s) for a happy path deployment. - Moved the getting-started to a more prominent location - Added a note about how to get the ingress subdomain/external IP for the webhook - Made a note of secret name from above step, and export the secreat to a yaml then edit namespace line to namespace and import secreat back - Added the value of "ExternalDomain" as a "minimal update" Signed-off-by: JJ Asghar <jjasghar@gmail.com> Co-authored-by: Adam Roberts <aroberts@uk.ibm.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the readme(s) for a happy path deployment.
subdomain/external IP for the webhook
export the secreat to a yaml then edit namespace line to namespace and
import secreat back
Signed-off-by: JJ Asghar jjasghar@gmail.com
Co-authored-by: Adam Roberts aroberts@uk.ibm.com