Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template.ref instead of template.name #787

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Use template.ref instead of template.name #787

merged 2 commits into from
Oct 14, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 5, 2020

Changes

Previously, we'd use the name field in triggers to refer to
TriggerTemplates. This commit deprecates the name field in favor of the ref
field. This makes the usage of ref consistent across bindings and
template.

name is still supported and will be removed in a future release.

Part of #616

I've split the changes to all examples/doc to use the ref field to a separate commit.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Use template.ref to refer to trigger templates in a Trigger instead of template.name. The name field is deprecated and will be removed in a future release.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 5, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2020
@dibyom dibyom changed the title Name to ref Use template.ref instead of template.name Oct 5, 2020
@dibyom
Copy link
Member Author

dibyom commented Oct 5, 2020

/hold

Depends on #783

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go 93.8% 93.0% -0.8
pkg/template/resource.go 100.0% 98.3% -1.7

@dibyom
Copy link
Member Author

dibyom commented Oct 5, 2020

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 5, 2020
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go 93.9% 93.2% -0.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go 93.9% 94.5% 0.6

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go 93.9% 94.5% 0.6

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go 93.9% 94.5% 0.6

@dibyom
Copy link
Member Author

dibyom commented Oct 13, 2020 •
edited
Loading

/cc @savitaashture @khrm
/hold cancel

@dibyom dibyom removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2020
@dibyom
Use ref to refer to TriggerTemplates
160b0d6 
Previously, we'd use the `name` field in `triggers` to refer to
TriggerTemplates. This commit deprecates the `name` field in favor of the `ref`
field. This makes the usage of `ref` consistent across `bindings` and
`template`.

`name` is still supported and will be removed in a future release.

Part of tektoncd#616

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom
Migrate all usages of template.name to template.ref
e8990b6 
Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
savitaashture
savitaashture reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
wlynch
wlynch approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@tekton-robot tekton-robot merged commit 6fbcf89 into tektoncd:master Oct 14, 2020
@dibyom dibyom deleted the nameToRef branch October 14, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@wlynch wlynch wlynch approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@khrm khrm Awaiting requested review from khrm

Assignees

@wlynch wlynch

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibyom @tekton-robot @wlynch @savitaashture