[CHERRY-PICK] Merge extensions into body for webhook interceptors #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With CEL interceptor writing to the `extensions` field, it is impossible to chain added fields from a CEL interceptor to a webhook interceptor today. This is because we do not pass the extensions field to the webhook interceptor yet. This commit attempts to fix this by merging any extensions to the body before sending it over to the Webhook interceptor. This is temporary until we fully move webhook interceptors to the new pluggable interface. One implication of this change is that the body may now contain an `extensions` field separate from the top level extensions field if one uses the Webhook interceptor. In addition, the CEL environment also did not have access to extensions which I fixed. Fixes tektoncd#857 Signed-off-by: Dibyo Mukherjee <dibyo@google.com> Add extensions support to CEL
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
dibyom
changed the title
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick of a079952 for release v0.10.2
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
/assign @khrm