Move core interceptors to their own server #878

dibyom · 2020-12-23T16:42:13Z

Changes

The EventListener will forward events over HTTP to the interceptor. Each core
interceptor is available at a different path e.g. /cel for CEL.

Fixes #867

Depends on #877

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Core interceptors now run in their own server that is deployed in the tekton-pipelines namespace.

tekton-robot · 2020-12-23T16:43:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	58.4%	-31.6
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-23T19:57:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	58.4%	-31.6
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-23T22:26:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	58.4%	-31.6
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-29T17:13:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-30T17:34:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

The EventListener will forward events over HTTP to the interceptor. Each core interceptor is available at a different path e.g. /cel for CEL. Fixes tektoncd#867 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

tekton-robot · 2020-12-30T23:01:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-31T00:02:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

tekton-robot · 2020-12-31T00:17:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

dibyom · 2020-12-30T17:28:57Z

pkg/interceptors/interceptors.go

 // Interceptor is the interface that all interceptors implement.
 type Interceptor interface {
 	ExecuteTrigger(req *http.Request) (*http.Response, error)
 }

 type key string

-const requestCacheKey key = "interceptors.RequestCache"
+const RequestCacheKey key = "interceptors.RequestCache"


this cache isn't really being used. I'll replace it with a lister/informer for secrets in a followup. (only need to export it for one test that is using it).

wlynch

looks good! few minor comments.

cmd/interceptors/main.go

pkg/interceptors/interceptors_test.go

pkg/interceptors/interceptors.go

pkg/sink/sink_test.go

test/init_test.go

tekton-robot · 2021-01-06T02:07:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.5%	0.5

1. Log CRDs as JSON so that we can print out the resource templates instead of a raw byte array 2. Capture and dump logs for core interceptor pod 3. Fix EL logs - they were using the wrong label to query

tekton-robot · 2021-01-06T02:11:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.2%	2.2
pkg/sink/sink.go	78.1%	78.1%	0.1

tekton-robot · 2021-01-06T16:21:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	90.0%	92.1%	2.1
pkg/sink/sink.go	78.1%	78.4%	0.3

wlynch

/lgtm

tekton-robot · 2021-01-07T18:36:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 23, 2020

tekton-robot requested review from bobcatfish and wlynch December 23, 2020 16:42

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 23, 2020

dibyom added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 23, 2020

dibyom force-pushed the http_main branch from 8c5573c to 4f6396b Compare December 23, 2020 19:55

dibyom force-pushed the http_main branch from 4f6396b to 23cf900 Compare December 23, 2020 22:25

dibyom force-pushed the http_main branch from 23cf900 to fae4415 Compare December 29, 2020 17:11

dibyom force-pushed the http_main branch from fae4415 to 128fd62 Compare December 30, 2020 17:33

dibyom marked this pull request as ready for review December 30, 2020 17:37

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2020

dibyom mentioned this pull request Dec 30, 2020

Refactor sink test #882

Merged

4 tasks

Move core interceptors to their own server

038a95e

The EventListener will forward events over HTTP to the interceptor. Each core interceptor is available at a different path e.g. /cel for CEL. Fixes tektoncd#867 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

dibyom force-pushed the http_main branch from 128fd62 to 3bd489d Compare December 30, 2020 23:00

dibyom force-pushed the http_main branch from 3bd489d to 9eb9e66 Compare December 31, 2020 00:01

dibyom force-pushed the http_main branch from 9eb9e66 to d8a3077 Compare December 31, 2020 00:15

dibyom commented Jan 5, 2021

View reviewed changes

dibyom assigned wlynch Jan 5, 2021

wlynch reviewed Jan 5, 2021

View reviewed changes

dibyom force-pushed the http_main branch from d8a3077 to 6faf0f2 Compare January 6, 2021 02:05

test: fix e2e test logging

1705278

1. Log CRDs as JSON so that we can print out the resource templates instead of a raw byte array 2. Capture and dump logs for core interceptor pod 3. Fix EL logs - they were using the wrong label to query

dibyom force-pushed the http_main branch from 6faf0f2 to 1705278 Compare January 6, 2021 02:10

Build URL instead of parsing it out of a string

dac3a2f

dibyom requested a review from wlynch January 7, 2021 15:59

wlynch approved these changes Jan 7, 2021

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021

tekton-robot merged commit 4973464 into tektoncd:master Jan 7, 2021

dibyom deleted the http_main branch January 7, 2021 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move core interceptors to their own server #878

Move core interceptors to their own server #878

dibyom commented Dec 23, 2020

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 29, 2020

tekton-robot commented Dec 30, 2020

tekton-robot commented Dec 30, 2020

tekton-robot commented Dec 31, 2020

tekton-robot commented Dec 31, 2020

dibyom Dec 30, 2020 •

edited

Loading

wlynch left a comment

tekton-robot commented Jan 6, 2021

tekton-robot commented Jan 6, 2021

tekton-robot commented Jan 6, 2021

wlynch left a comment

tekton-robot commented Jan 7, 2021

Move core interceptors to their own server #878

Move core interceptors to their own server #878

Conversation

dibyom commented Dec 23, 2020

Changes

Submitter Checklist

Release Notes

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 23, 2020

tekton-robot commented Dec 29, 2020

tekton-robot commented Dec 30, 2020

tekton-robot commented Dec 30, 2020

tekton-robot commented Dec 31, 2020

tekton-robot commented Dec 31, 2020

dibyom Dec 30, 2020 • edited Loading

Choose a reason for hiding this comment

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 6, 2021

tekton-robot commented Jan 6, 2021

tekton-robot commented Jan 6, 2021

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 7, 2021

dibyom Dec 30, 2020 •

edited

Loading