Publish DPT example script #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@ningai85 I believe you need to click the link in the CLA Assistant to submit a CLA. |
1. Adding time out input to the wait_for_scope_free(time_out_sec) function;
2. Adding 2 time delay command (time.sleep(1)) in the beginning and end of wait_for_scope_free(time_out_sec);
3. Comments print('all event messages: {}'.format(r)) in read_wfm_vertical()
4. Adding time.sleep(1) in the 3rd line of wait_for_scope_acq_stop_or_timeout()
5. Remove DUT type setting scope.write('MEASUrement:WBG:PDEVice MOSFET')
6. Adding MATH channel defination in # Set the WBG-DPT test items blockscope.write('MATH:' + id_mea_str + ':DEFine \"' + id_chn_str + '\"')
7. Adding current offset compensation condition to script (2 locations)
if id_zero_gate_beg != id_zero_gate_end:
8. Delete the status checking
r = int(scope.query('*esr?'))
r = scope.query('allev?').strip()
9. Put the customer settings in an order with 2 groups (basic/advanced)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please review the Contribution Guidelines before submitting.
masterbranch (left side).Type (Select only one)
Description
Double pulse test application notes plus the example script review application,
If there is any issues or concerns or unclear situations, please contact me.