Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ckan check resource view list #2151

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega changed the title [WIP] Fix/ckan check resource view list Fix/ckan check resource view list Apr 8, 2022
@AlvaroVega AlvaroVega requested a review from fgalan April 18, 2022 09:13
@AlvaroVega
Copy link
Member Author

The main change of this PR is the evaluation of the result, changing from >0 to >= 0
And also logging result of evaluation, because before this PR some times is logging ok but returning non ok.

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit ac5342c into master Apr 25, 2022
@fgalan fgalan deleted the fix/ckan_check_resource_view_list branch April 25, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants