Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ArcgisFeatureTable.java #2321

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Update ArcgisFeatureTable.java #2321

merged 2 commits into from
Nov 15, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Nov 14, 2023 •
edited
Loading

@AlvaroVega AlvaroVega marked this pull request as ready for review November 14, 2023 11:03
@AlvaroVega
Copy link
Member Author

needs #2322

fgalan
fgalan approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan
Copy link
Member

fgalan commented Nov 15, 2023

Pending on @danielvillalbamota LGTM to be merged.

danielvillalbamota
danielvillalbamota approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@danielvillalbamota danielvillalbamota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielvillalbamota danielvillalbamota merged commit 9748741 into master Nov 15, 2023
6 checks passed
@danielvillalbamota danielvillalbamota deleted the task/revert_has_attribute_lowercase_argcis branch November 15, 2023 15:23
@danielvillalbamota danielvillalbamota mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvillalbamota danielvillalbamota danielvillalbamota approved these changes

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @fgalan @danielvillalbamota