Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pagination: force order by name, offset and limit #50

Merged
merged 1 commit into from Dec 20, 2019
Merged

fix pagination: force order by name, offset and limit #50

merged 1 commit into from Dec 20, 2019

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 20, 2019 •
edited

fix #51

fgalan
fgalan approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 3613769 into master Dec 20, 2019
@fgalan fgalan deleted the fix/pagination_decorator branch December 20, 2019 09:11
@fgalan fgalan mentioned this pull request Dec 20, 2019
Closed
@AlvaroVega
Copy link
Member Author

This fix, forcing to sort by name, introduces a bug for keystone Newton and upper versions, since some tables like service does not have name as a column, an then query is not able to work,

@AlvaroVega AlvaroVega mentioned this pull request Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in pagination
2 participants
@AlvaroVega @fgalan