Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change project keys #41

Merged
merged 2 commits into from
Jan 30, 2015
Merged

Change project keys #41

merged 2 commits into from
Jan 30, 2015

Conversation

pratid
Copy link
Member

@pratid pratid commented Jan 29, 2015

Reviewers

@flopezag

Description

Adoption of IoT Platform's project key pattern

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.95% when pulling 259bdc4 on Fiware:develop into c9ae859 on telefonicaid:develop.

flopezag
flopezag reviewed Jan 29, 2015
View reviewed changes
ngsi_adapter/script/build/jenkins.sh
@@ -93,7 +93,7 @@ PRODUCT_RELEASE=$(echo "$PRODUCT_INFO" | sed -n '/"release"/ {s/.*:.*"\(.*\)".*/
PROJECT_NAME=$(sed -n '/"name"/ {s/.*:.*"\(.*\)".*/\1/; p; q}' $PROJECT_BASE_DIR/package.json)
PROJECT_VERSION=$(sed -n '/"version"/ {s/.*:.*"\(.*\)".*/\1/; p; q}' $PROJECT_BASE_DIR/package.json)
SONAR_PROJECT_NAME=$(echo "$PRODUCT_NAME-$PROJECT_NAME" | tr '_' '-')
SONAR_PROJECT_KEY=com.telefonica.fiware:$SONAR_PROJECT_NAME
SONAR_PROJECT_KEY=com.telefonica.IoT:$SONAR_PROJECT_NAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry:

com.telefonica.iot

@flopezag
Copy link
Member

la key del sonar debería ser:

com.telefonica.iot:monitoring-ngsi-adapter
com.telefonica.iot:monitoring-ngsi-eventbroker

y el sonar project name debería ser:

Monitoring NGSI Adapter
Monitoring NGSI Event Broker

@pratid
Copy link
Member Author

pratid commented Jan 29, 2015

Event Broker are two separate words. Do you really mean "ngsi-eventbroker" in the Sonar key? Or "ngsi-event-broker"?

@pratid
Copy link
Member Author

pratid commented Jan 29, 2015

Another question: the Linux packages for these two components are named:

fiware-monitoring-ngsi-adapter_{version}_{arch}.deb
fiware-monitoring-ngsi-event-broker_{version}_{arch}.deb

I find very useful and convenient to prepend "fiware-" to those names. Should we change prefix to "iot-"?

@flopezag
Copy link
Member

  1. PaaSManager are also 2 words and we decided to put together... It doesn't matter what is the name but internally we put it. If we change it now we should change in other place too. If you are happy with two separate words well say me that you adopt it.

  2. Why do you say that fiware-* is very useful and convenient, for my point of view it is redundant information that we should resolve, shouldn't?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.95% when pulling 67cb22d on Fiware:develop into c9ae859 on telefonicaid:develop.

@flopezag
Copy link
Member

LGTM

flopezag pushed a commit that referenced this pull request Jan 30, 2015
Merge pull request #41 from Fiware/develop
362d6a1 
Change project keys
@flopezag flopezag merged commit 362d6a1 into telefonicaid:develop Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pratid @coveralls @flopezag