ws:// processing at Notifier library #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,18 @@ | |||
| #include "ngsiNotify/senderThread.h" | |||
|
|
|||
|
|
|||
| // FIXME P11 #1669: remove this stub when the actual sendNotifyContextRequestWs() gets developed a the end. @fortizc please take care of this | |||
| // in the ws library | |||
| int sendNotifyContextRequestWs(const std::string& subId, const std::map<std::string, std::string>& headers, const std::string& data) | |||
There was a problem hiding this comment.
At the begining I proposed (at #1669) to use bool as return value for this function. However, in order to align with httpRequestSent() signature used at startSenderThread() function, I think it should be better to use int the the usual semantics: 0 -> everythin ok, not 0 -> error.
(I have edited signature at #1669 (comment) has been changed void -> int)
|
LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1669
Unfortunatelly, make ft is broken in feature/1181_websocket due to current WS implementation in that branch, I cannot assure this modification doesn't break anything...
@fortizc