Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX cache update logic #4070

Merged
merged 8 commits into from
Feb 28, 2022
Merged

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Feb 22, 2022

Issue #4069 and #4063

  • Review other issues solved by this PR
  • CNR
  • Review Devel Manual
    • Specially, looks for occurrences of mongoSubCountersUpdate() (in .md and diagrams) as that function as unfold into two separate functions: mongoSubUpdateOnNotif() and mongoSubUpdateOnCacheSync()

@fgalan fgalan changed the title FIX cache update logic [WIP] FIX cache update logic Feb 22, 2022
@fgalan fgalan force-pushed the bug/4069_status_wrong_update_in_cache branch from 1f0b094 to 5c9b2c0 Compare February 22, 2022 15:56
@@ -378,6 +378,12 @@ function localBrokerStart()
then
port=$CB_PORT
CB_START_CMD="$CB_START_CMD_PREFIX -port $CB_PORT -pidpath $CB_PID_FILE -dbhost $dbHost:$dbPort -db $CB_DB_NAME -dbPoolSize $POOL_SIZE -t $traceLevels $IPvOption $extraParams"
elif [ "$role" == "CBHA" ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To implement the test case for this PR (test/functionalTest/cases/4069_status_inactive_not_working_with_cache_in_ha/status_inactive_not_working_with_cache_in_ha.test) we have needed to extend the testing framework with a new role: CB for HA testing. It's like the usual CB but sharing the same database.

Thus, new HA cases can be tested from now on :)

NTC (informative)

@fgalan fgalan changed the title [WIP] FIX cache update logic FIX cache update logic Feb 28, 2022
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit c9522a8 into master Feb 28, 2022
@AlvaroVega AlvaroVega deleted the bug/4069_status_wrong_update_in_cache branch February 28, 2022 14:54
@cesarjorgemartinez
Copy link
Contributor

LGTM

@fgalan
Copy link
Member Author

fgalan commented Feb 28, 2022

@fisuda this PR does some modification in .md documents. It would be great if you could synchronize in the Japanese translation, please. Thanks!

fisuda added a commit to fisuda/fiware-orion that referenced this pull request Mar 1, 2022
@fisuda
Copy link
Contributor

fisuda commented Mar 1, 2022

I sent the PR #4075.
Thanks.

fgalan added a commit that referenced this pull request Mar 1, 2022
(JP) Update doc about cache update logic (#4070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants