-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX cache update logic #4070
FIX cache update logic #4070
Conversation
1f0b094
to
5c9b2c0
Compare
@@ -378,6 +378,12 @@ function localBrokerStart() | |||
then | |||
port=$CB_PORT | |||
CB_START_CMD="$CB_START_CMD_PREFIX -port $CB_PORT -pidpath $CB_PID_FILE -dbhost $dbHost:$dbPort -db $CB_DB_NAME -dbPoolSize $POOL_SIZE -t $traceLevels $IPvOption $extraParams" | |||
elif [ "$role" == "CBHA" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To implement the test case for this PR (test/functionalTest/cases/4069_status_inactive_not_working_with_cache_in_ha/status_inactive_not_working_with_cache_in_ha.test) we have needed to extend the testing framework with a new role: CB for HA testing. It's like the usual CB but sharing the same database.
Thus, new HA cases can be tested from now on :)
NTC (informative)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
@fisuda this PR does some modification in .md documents. It would be great if you could synchronize in the Japanese translation, please. Thanks! |
I sent the PR #4075. |
(JP) Update doc about cache update logic (#4070)
Issue #4069 and #4063