Update ci.yml #522
Update ci.yml #522
Conversation
Add Node 14 to unit-test matrix
Consequence of merging telefonicaid/iotagent-node-lib#854
docs/deprecated.md
Outdated
| - Support to Node.js v4 in iotagent-json 1.9.0. The use of Node.js v8 is highly recommended. | ||
| - Support to Node.js v10 in iotagent-json 1.17.0. The use of Node.js v12 is highly recommended. |
There was a problem hiding this comment.
For the sake of completeness, maybe information about versions between v4 and v10 should be included (it should be easy to know looking at https://github.com/telefonicaid/iotagent-json/releases )... although maybe it doesn't worth the time.
Not sure how it's better...
| "type": "geo:point", | ||
| "value": "0, 0" | ||
| "type": "geo:json", | ||
| "value": {"type":"Point","coordinates":[0,0]} |
There was a problem hiding this comment.
Shouldn't be unit test failing before this fix (I mean, in master)?
There was a problem hiding this comment.
If you re-start the last run it should now fail. The change has occurred in the downstream iotagent-node-lib
"iotagent-node-lib": "git://github.com/telefonicaid/iotagent-node-lib.git#master",... is now picking up telefonicaid/iotagent-node-lib@a7eb260 commited 20 days ago, but the last CI test run was 23 days ago.
There was a problem hiding this comment.
Re-run in master and failed. Everything ok.
NTC
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Add Node 14 to unit-test matrix