allow receive single HTTP measures using attribute values in plain, raw and json content-types #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroVega
changed the title
|
Based in bodyparser custom middleware described in https://stackoverflow.com/questions/54226441/body-parser-use-bodyparser-middleware-from-another-middleware |
|
Default attribute type used by MQTT when a single measrue is receive from |
AlvaroVega
changed the title
AlvaroVega
changed the title
|
Should a twin PR be done for IOTA-UL? |
fgalan
reviewed
May 31, 2022
This issue does not applies to iota-ul |
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
fgalan
reviewed
May 31, 2022
CHANGES_NEXT_RELEASE
Outdated
Comment on lines
1
to
4
| - Add: allow receive single HTTP attribute measures posted to `/iot/json/attrs/<attributeName>` with different content-types `application/json`, `text/plain` and `application/octet-stream` | ||
| - Upgrade body-parser dep from 1.18.3 to 1.20.0 | ||
| - Upgrade express dep from ~4.16.4 to 4.18.1 | ||
| - Fix: do not use json parse strict for incoming http measures, commands and configuration |
There was a problem hiding this comment.
Issue #661 should be cited (not sure if in the "Add:" line, in the "Fix:" line or in both)
fgalan
reviewed
May 31, 2022
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #661
/iot/json/attrs/:attrValueallowing these content-types:application/json,text/plain,application/octet-streamThis PR enables send single measures like:
curl -i -X POST 'http://localhost:7897/iot/json/attrs/myattr1?i=disp4&k=6idn7z9cba3o57tgoascazdwd' -d '33' -H 'content-type: application/json'
curl -i -X POST 'http://localhost:7897/iot/json/attrs/myattr1?i=disp4&k=6idn7z9cba3o57tgoascazdwd' -d 'asdfasdfasd' -H 'content-type: text/plain'
curl -i -X POST 'http://localhost:7897/iot/json/attrs/myattr1?i=disp4&k=6idn7z9cba3o57tgoascazdwd' -d '01010011' -H 'content-type: application/octet-stream'