Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ensure entity id and type is string (fix for master) #1487

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Fix/ensure entity id and type is string (fix for master) #1487

merged 11 commits into from
Oct 4, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 3, 2023 •
edited by fgalan
Loading

Issue #1476

@AlvaroVega AlvaroVega changed the title [WIP] Fix/ensure entity id string (fix for master) Fix/ensure entity id string (fix for master) Oct 3, 2023
@AlvaroVega AlvaroVega marked this pull request as ready for review October 3, 2023 08:53
fgalan
fgalan reviewed Oct 3, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@AlvaroVega @fgalan
Update package.json
e191a3c 
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
@AlvaroVega AlvaroVega mentioned this pull request Oct 3, 2023
Merged
@AlvaroVega AlvaroVega changed the title Fix/ensure entity id string (fix for master) Fix/ensure entity id and type is string (fix for master) Oct 3, 2023
@fgalan fgalan mentioned this pull request Oct 3, 2023
Closed
fgalan
fgalan approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I think it will be wise to wait a while for merging, while we check how hotfixes 3.4.x are working.

@fgalan fgalan merged commit 54a625f into master Oct 4, 2023
7 checks passed
@fgalan fgalan deleted the fix/ensure_entity_id_string_master branch October 4, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan