add multiple delete of devices

[AlvaroVega]

issue #1578

[fgalan]

A delete method with body is not fully restful but is not so ilegal, but we can look for other methods. @fgalan what do you think?

It is not illegal, but not sure if some network middleware (proxies, etc.) could have issues with this. Maybe it's better to avoid this risk using another approach.

Maybe we could use POST /iot/op/delete. This makes explicit that we are not using a REST operation (as we are not acting on a given resource, i.e. a device in IOAT API terms) but a kind of RPC operation (this is similar to the approach used in Orion API with the POST /v2/op operations family).

[AlvaroVega]

A delete method with body is not fully restful but is not so ilegal, but we can look for other methods. @fgalan what do you think?

It is not illegal, but not sure if some network middleware (proxies, etc.) could have issues with this. Maybe it's better to avoid this risk using another approach.

Maybe we could use POST /iot/op/delete. This makes explicit that we are not using a REST operation (as we are not acting on a given resource, i.e. a device in IOAT API terms) but a kind of RPC operation (this is similar to the approach used in Orion API with the POST /v2/op operations family).

Taking a look to resource already used by device API:

iotagent-node-lib/lib/services/northBound/deviceProvisioningServer.js

Lines 438 to 468 in 7320146

	function loadContextRoutes(router) {
	router.post(
	'/iot/devices',
	restUtils.checkRequestAttributes('headers', mandatoryHeaders),
	restUtils.checkBody(createDeviceTemplate),
	handleProvision
	);
	router.get('/iot/devices', restUtils.checkRequestAttributes('headers', mandatoryHeaders), handleListDevices);
	router.get(
	'/iot/devices/:deviceId',
	restUtils.checkRequestAttributes('headers', mandatoryHeaders),
	handleGetDevice
	);
	router.put(
	'/iot/devices/:deviceId',
	restUtils.checkRequestAttributes('headers', mandatoryHeaders),
	restUtils.checkBody(updateDeviceTemplate),
	handleUpdateDevice
	);
	router.delete('/iot/devices', restUtils.checkRequestAttributes('headers', mandatoryHeaders), handleRemoveDevices);
	router.delete(
	'/iot/devices/:deviceId',
	restUtils.checkRequestAttributes('headers', mandatoryHeaders),
	handleRemoveDevice
	);
	}

I was looking for something like POST /iot/devices/delete

[fgalan]

I understand (as seen in commit 9752b31) that at the end we are going to use POST /iot/op/delete.

[fgalan]

Should functional test (i.e. the ones within /test/functional/) to be included?

[AlvaroVega]

Not sure if there is support for northbound api in functional tests. @mapedraza is there support for that ?

[mapedraza]

So far, it is not supported northbound only tests (the tests consits of 3 steps, group provision, measure send and CB validation). No so hard to add support adding another "type" of test that check only the northbound using the same test infrastructure. I suggest to merge this like this and create an issue to implement what is describe in this comment.

[fgalan]

Issue created: #1581 (please feel free to comment on it if something is missing/wrong)

NTC

[fgalan]

LGTM