Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service and subservice (and pep usage) for updateAction #435

Merged
merged 10 commits into from
Feb 28, 2020
Merged

add service and subservice (and pep usage) for updateAction #435

merged 10 commits into from
Feb 28, 2020

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Feb 27, 2020 •
edited
Loading

issue #349

  • ngsi v1
  • ngsi v2
  • Ensure use orion pep endpoint if service/subservice is provided

@AlvaroVega AlvaroVega changed the title [WIP] add service and subservice for updateAction ngsi v1 [WIP] add service and subservice for updateAction Feb 27, 2020
@AlvaroVega AlvaroVega changed the title [WIP] add service and subservice for updateAction add service and subservice for updateAction Feb 27, 2020
@AlvaroVega AlvaroVega closed this Feb 27, 2020
@AlvaroVega AlvaroVega reopened this Feb 27, 2020
@AlvaroVega AlvaroVega changed the title add service and subservice for updateAction [WIP] add service and subservice for updateAction Feb 27, 2020
@AlvaroVega AlvaroVega changed the title [WIP] add service and subservice for updateAction [WIP] add service and subservice (and pep usage) for updateAction Feb 27, 2020
@AlvaroVega AlvaroVega changed the title [WIP] add service and subservice (and pep usage) for updateAction add service and subservice (and pep usage) for updateAction Feb 27, 2020
manucarrace
manucarrace approved these changes Feb 27, 2020
View reviewed changes
Copy link
Collaborator

@manucarrace manucarrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgalan
fgalan reviewed Feb 27, 2020
View reviewed changes
lib/models/updateAction.js
@@ -166,12 +172,16 @@ function doRequest(action, event, token, callback) {
headers[constants.SUBSERVICE_HEADER] = subservice;
headers[constants.SERVICE_HEADER] = service;

var orionUrl = config.orion.URL;
if (options.service !== undefined || options.subservice !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New service and subservices field should be documented in actions document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4d1be16

manucarrace
manucarrace approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@manucarrace manucarrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgalan
fgalan approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit ddf7f9f into master Feb 28, 2020
@fgalan fgalan deleted the task/add_service_subservice_update_action branch February 28, 2020 07:33
@fgalan fgalan mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucarrace manucarrace manucarrace approved these changes

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @fgalan @manucarrace