[v2] Properly retry on hiccups on the SOCKS server #1598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@esmet reports that he sees AES CI flakes where a hiccup in the connection to the cluster causes the whole connector to quit. It should have retries! Well, it turns out that while most of the things had retries, the
/connector/server-socks
goroutine didn't retry, and so it'd error out, and cause all the rest of it to shut down.As usual, I suggest a commit-by-commit review:
tm.sshPort
to make sure that all users of it properly retry.Checklist
./CHANGELOG.md
. - yesDEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently. - no tricks