Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Properly retry on hiccups on the SOCKS server #1598

Merged
merged 7 commits into from
Mar 24, 2021

Conversation

LukeShu
Copy link
Contributor

@LukeShu LukeShu commented Mar 23, 2021

Description

@esmet reports that he sees AES CI flakes where a hiccup in the connection to the cluster causes the whole connector to quit. It should have retries! Well, it turns out that while most of the things had retries, the /connector/server-socks goroutine didn't retry, and so it'd error out, and cause all the rest of it to shut down.

As usual, I suggest a commit-by-commit review:

  • The first 3 commits are doing prep-work for the fix, with an eye for auditing uses of tm.sshPort to make sure that all users of it properly retry.
  • The 4th commit is the actual fix.
  • The final 2 commits are generic cleanup tasks that are now-trivial and now-obvious because of the changes made above.

Checklist

  • I made sure to update ./CHANGELOG.md. - yes
  • I made sure to either submit a docs PR, or tell Matt about the necessary documentation changes. - no applicable changes
  • My change is adequately tested. - no
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently. - no tricks

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
So move it to the traffic manager.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Copy link
Member

@thallgren thallgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
@LukeShu LukeShu merged commit 1f299ce into release/v2 Mar 24, 2021
@LukeShu LukeShu deleted the lukeshu/for-jesmet branch March 24, 2021 18:47
@khussey khussey added this to the 2021 Cycle 3 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants