Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tooltip): update tooltip in grid kb #1785

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

YanushevGeorgi
Copy link
Contributor

No description provided.

@YanushevGeorgi YanushevGeorgi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Nov 27, 2023
@YanushevGeorgi YanushevGeorgi requested a review from a team November 27, 2023 16:50
@YanushevGeorgi YanushevGeorgi self-assigned this Nov 27, 2023
@YanushevGeorgi YanushevGeorgi requested a review from a team as a code owner November 27, 2023 16:50
Copy link
Contributor

Hello @YanushevGeorgi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

1. Use a [Column(cell) Template]({%slug grid-templates-column%}) to wrap the cell's value in a `<span>`.
1. Attach the [`TelerikToolTip`]({%slug tooltip-overview%}) to the `<span>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is not specific enough. You can mention the Tooltip TargetSelector parameter here.

private List<BasicEmployee> GridData { get; set; }

protected override async Task OnAfterRenderAsync(bool firstRender)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation may look strange at first. You can add a comment that this approach shows that the Tooltip will work even if the Grid is bound after the Tooltip is initialized.

}

public class EmployeeDetailsModel : BasicEmployee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is over engineered. Is this needed? Consider simplifying.

Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the model class definition

@@ -4,16 +4,123 @@ description: How to add Tooltips in Grid columns.
page_title: Tooltip in Grid
slug: tooltip-kb-in-grid
position:
tags:
tags: telerik, blazor, grid, tooltip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description, it must contain around 150 symbols.

@dimodi dimodi merged commit cadf7b8 into master Dec 5, 2023
1 check passed
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Here you are the link to your PR to production: 1799

@github-actions github-actions bot deleted the tooltip-in-grid-update branch December 5, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants