-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tooltip): update tooltip in grid kb #1785
Conversation
Hello @YanushevGeorgi, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
knowledge-base/tooltip-in-grid.md
Outdated
1. Use a [Column(cell) Template]({%slug grid-templates-column%}) to wrap the cell's value in a `<span>`. | ||
1. Attach the [`TelerikToolTip`]({%slug tooltip-overview%}) to the `<span>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is not specific enough. You can mention the Tooltip TargetSelector
parameter here.
private List<BasicEmployee> GridData { get; set; } | ||
|
||
protected override async Task OnAfterRenderAsync(bool firstRender) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation may look strange at first. You can add a comment that this approach shows that the Tooltip will work even if the Grid is bound after the Tooltip is initialized.
knowledge-base/tooltip-in-grid.md
Outdated
} | ||
|
||
public class EmployeeDetailsModel : BasicEmployee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is over engineered. Is this needed? Consider simplifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify the model class definition
@@ -4,16 +4,123 @@ description: How to add Tooltips in Grid columns. | |||
page_title: Tooltip in Grid | |||
slug: tooltip-kb-in-grid | |||
position: | |||
tags: | |||
tags: telerik, blazor, grid, tooltip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the description, it must contain around 150 symbols.
Here you are the link to your PR to production: 1799 |
No description provided.