Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(filter): dropdowns auto width #866

Merged
merged 2 commits into from
Sep 10, 2019
Merged

chore(filter): dropdowns auto width #866

merged 2 commits into from
Sep 10, 2019

Conversation

TeyaVes
Copy link
Contributor

@TeyaVes TeyaVes commented Sep 3, 2019

No description provided.

@TeyaVes TeyaVes self-assigned this Sep 3, 2019
joneff
joneff suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@joneff joneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a chore. It actually changes how things look, so it should be a "fix". Then we have components with variable width: consider "And" and "Or".

Is there a feedback item / design on which the change is based?

@joneff joneff mentioned this pull request Sep 4, 2019
Closed
@joneff joneff merged commit 25880e2 into develop Sep 10, 2019
@joneff joneff deleted the filter-dropdown branch September 10, 2019 13:15
@joneff joneff added this to the 2020.1 milestone Jan 25, 2022
@joneff joneff added C:Filter Enhancement New feature of an existing functionality or an improvement of an existing functionality. labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneff joneff joneff approved these changes

@PreslavKozovski PreslavKozovski PreslavKozovski approved these changes

Assignees

@TeyaVes TeyaVes

Labels
C:Filter Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Milestone
2020.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TeyaVes @joneff @PreslavKozovski