Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling #2

Closed
duff opened this issue Apr 20, 2011 · 6 comments
Closed

Scrolling #2

duff opened this issue Apr 20, 2011 · 6 comments
Assignees

Comments

@duff
Copy link

duff commented Apr 20, 2011

I'm curious if allowing scrolling using vim like keystrokes (j for down, k for up, maybe d for page up, and u for page up) is something that you think would be worthwhile.

@ghost ghost assigned guyht Apr 20, 2011
@guyht
Copy link
Collaborator

guyht commented Apr 21, 2011

I agree. This functionality is available in vimium, but has not yet been fully ported to vimari. Porting these features across should be fairly easy. The reason they were overlooked in the first place was because I was concentrating on the 'quick link' features.

If anyone wishes to work on this feel free, otherwise I will have a look at it next week.

G

@duff
Copy link
Author

duff commented Apr 21, 2011

Sounds great! I'll let you know if I go after it.

At first, I was unsure of having to use the ctrl key. But it does seem to make things simpler in that it appears to work regardless of whether you're in insert mode or normal mode. And one of the great things about having it in GH is that I can adjust it to a different modifier in my fork if I'd like.

@guyht
Copy link
Collaborator

guyht commented Apr 21, 2011

Cool, feel free to fork it and have a dig around. The port is pretty rustic at the moment but would be good to see some more work on it.

@guyht
Copy link
Collaborator

guyht commented Jul 5, 2011

@duff I am going to be putting some work into porting some missing features from the chrome version (vimium) into this project. Some tickets will be created over the next few days but I would also like to be able to include the work you have done on getting scrolling to work. If this is ok with you could you please open a pull request.

Thanks

@duff
Copy link
Author

duff commented Jul 5, 2011

The scrolling work I did was in this commit:
duff@aadf110

I don't know that you'd want the entire commit though since I customized some other things as well. Feel free to grab any of the parts there that you think would be useful.

@guyht
Copy link
Collaborator

guyht commented Sep 13, 2011

Closing this issue as scrolling is now supported. See issue #6

@guyht guyht closed this as completed Sep 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants