Add scrolling #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds scrolling basic functionality. The default bindings are similar to the canonical Vim commands: 'CTRL-j' to scroll down and 'CTRL-k' to scroll up. (These bindings are configurable.) This also fixes a typo where the tabForward and tabBackward settings were reversed.
|
Awesome, thanks, will test this tonight and merge / publish the update. G |
|
Sure thing -- I'm happy to help wherever I can. As a recent convert from Chrome to Safari, Vimari has been great. Thanks for starting the project. |
|
This has now been pulled into master and added to release 1.4, which should show up as an automatic update in safari->preferences->extensions The direct download can be found here: https://s3.amazonaws.com/static.cach.me/vimari/vimari-1.4.safariextz Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic scrolling functionality. The default bindings
are similar to the canonical Vim commands: 'CTRL-j' to scroll down
and 'CTRL-k' to scroll up. (These bindings are configurable.)
This also fixes a typo where the tabForward and tabBackward settings
were reversed.