delete_previous_comments has no effect

[vixus0]

I'm passing delete_previous_comments: true in the parameters to my put step on this resource, along with comment: my comment. Check status is updated, the new comment gets added but the previous comments are not removed.

I'm using a GitHub app token with read & write permissions on pull requests. Is there anything I'm missing?

[rickardl]

Hi,

Have you tried modifying the E2E test, that's available? Look at TestPutCommentsE2E and modify the underlying owner of the repo, to match one you're using and get back to us with the result.

[vixus0]

@rickardl I'll give that a try, thanks.

[bee-san]

Hey 👋🏻

I had a similar issue, specifically:

• My user was a GitHub Bot App
• It didn't delete comments
• Using OAuth on a personal account it did.
  The issue occurs here:

github-pr-resource/github.go

Line 398 in 9ec47e2

if e.Node.Author.Login == getComments.Viewer.Login {

When evaluating, it comes out to:

+ if "githubApp" == "githubApp[bot]"
- if e.Node.Author.Login == getComments.Viewer.Login {

Specifically, getComments.Viewer.Login returns the name with [bot] but e.Node.Author.Login returns it without bot.

[bgandon]

Thanks @bee-san for the fix in monzo#4! I've ported it to the new repo and it will soon be shipped.

Because unfortunately, there is no hope that one can get any further support here (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Maybe you guys can give a try and provide feedback there?

(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)