Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download m3u playlist functionality #15

Merged
merged 13 commits into from
Feb 16, 2018
Merged

Add download m3u playlist functionality #15

merged 13 commits into from
Feb 16, 2018

Conversation

hazcod
Copy link
Contributor

@hazcod hazcod commented Feb 12, 2018

Still uses -file, but if it starts with http (case-insensitive) it will try to download it to the OS tempdir + telly.m3u and remove it afterwards.

This was referenced Feb 12, 2018
@tombowditch
Copy link
Collaborator

Nice job @hazcod! I'll review this later today and merge - I'll also do the same to your Docker PR.

T

@tombowditch
Copy link
Collaborator

Looking good - I wonder if -m3u is a better option if we're adding URLs to the -file argument? Opinions please ;-)

@hazcod
Copy link
Contributor Author

hazcod commented Feb 12, 2018

Perhaps -playlist? Numbers in an argument feel a bit weird to the touch.

@cesalo
Copy link

cesalo commented Feb 12, 2018

+1 for playlist.

@hazcod
Copy link
Contributor Author

hazcod commented Feb 12, 2018

@tombowditch I renamed it to -playlist in the last two commits, let me know what you think.

@tombowditch
Copy link
Collaborator

Looks good. Can we add a -file that just kills telly and tells you to update it to -playlist just for legacy support - will only add it for one release and then remove it.

@hazcod
Copy link
Contributor Author

hazcod commented Feb 12, 2018

@tombowditch , see last commit. Using -file will throw a warning and overwrite -playlist.

@hazcod
Copy link
Contributor Author

hazcod commented Feb 13, 2018

Changed my mind, it now exits telly. If you don't shut it down, people will keep on using it.

@tombowditch
Copy link
Collaborator

Right, sounds good. This looks good to merge.

main.go Outdated
@@ -131,8 +131,8 @@ func main() {
// TODO: remove m3uFileOld
// give warning about -file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment relevant anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, warning has been implemented.

@hazcod
Copy link
Contributor Author

hazcod commented Feb 16, 2018

I fixed it for you, should be good now. We're getting there.. ;-)

@tombowditch
Copy link
Collaborator

😛

@tombowditch tombowditch merged commit e5cca1c into tellytv:master Feb 16, 2018
@hazcod hazcod deleted the feat-downloadm3u branch February 16, 2018 21:20
@tombowditch
Copy link
Collaborator

Many thanks for doing this 👍

@tombowditch
Copy link
Collaborator

I'll release a new release shortly...

@cesalo
Copy link

cesalo commented Feb 21, 2018

quick question .. if this is downloading the m3u file directly from http .. shouldn't also add the comma missing (#EXTINF:0 ->#EXTINF:0,) in most of the m3u files out there like vader by default? :). Just an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants