Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

now we can move all to savings in rex #735

Merged
merged 1 commit into from
Jul 31, 2023
Merged

now we can move all to savings in rex #735

merged 1 commit into from
Jul 31, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jul 31, 2023 •
edited
Loading

Fixes #734

Description

Minor bug fix to allow the user to put all (max available) amount to savings in REX.

Test scenarios

  • go to this link and login
  • go to wallet / REX / savings
  • press the max-available button (displaying how much you have on top of the input field)
  • press the "Move to savings" button.
    • It should work!

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Jul 31, 2023 that may be closed by this pull request
Can't move ALL to savings in REX #734
Closed
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 1ff9ac6
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/64c7b1f38a981a000850451f
😎 Deploy Preview https://deploy-preview-735--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 1ff9ac6
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/64c7b1f3a5d42500082abd94
😎 Deploy Preview https://deploy-preview-735--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the base branch from master to develop July 31, 2023 13:07
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ff9ac6
Status: ✅  Deploy successful!
Preview URL: https://155ddb7a.open-block-explorer.pages.dev
Branch Preview URL: https://734-cant-move-all-to-savings.open-block-explorer.pages.dev

View logs

@Viterbo Viterbo self-assigned this Jul 31, 2023
@Viterbo Viterbo requested a review from poplexity July 31, 2023 13:10
@donnyquixotic donnyquixotic merged commit 22f4d17 into develop Jul 31, 2023
10 checks passed
@donnyquixotic donnyquixotic deleted the 734-cant-move-all-to-savings-in-rex branch July 31, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnyquixotic donnyquixotic donnyquixotic approved these changes

@poplexity poplexity Awaiting requested review from poplexity

Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't move ALL to savings in REX
2 participants
@Viterbo @donnyquixotic