-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repairing the total balance calculation #110
repairing the total balance calculation #110
Conversation
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for wallet-testnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The balances seem to show correctly now. I have verified with EOS-Authority which is a match, and OBE (2 TLOS difference on my tested account though which equals staked resources), needs to be address separately for OBE @karynemayer @donnyquixotic
For the REX balance there is an issue with an edge case, where an account holds REX and REX Savings as the full amount of both is shown (no differentiation inside the balance), which can not be withdrawn with the web wallet and thus leads to an error when trying to remove all. This should be fixed with full code refactoring for Telos Station. @Viterbo
There is still an issue with "strange tokens" showing up though, both on Safari and Chrome, which should be fixed in the next sprint.
…esign-the-presentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected for Balance part and change of balances.
…esign-the-presentation
…entation' of https://github.com/telosnetwork/telos-wallet into 94-repair-the-balance-calculation-and-redesign-the-presentation
@Kersten-CR,
In the near future spring, we can address the refactoring task which will be a definitive and clean solution. Also, I created this issue (#126) to address the custom token list problems. |
Fixes #94
Description
The calculation was fixed as described in issue #94. The display part was not implemented due to a previous discussion where we agreed to skip that part because it will be refactored anyway in the near future.
Test scenarios
Let's call
myaccount
any account you control with the following balances:test scenarios 1
myaccount
in web-wallettest scenarios 2
myaccount
in web-walletChecklist: