Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/token list reordering #138

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Feb 21, 2023

Fixes #139

Test scenarios

  • log in with account hyogaserelou (or other account with proposal, dao, vote tokens)
  • view wallet, table should not continuously shift order of tokens in table

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file
  • I have created a new issue with the required translations for the currently supported languages

@donnyquixotic donnyquixotic self-assigned this Feb 21, 2023
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 87f8f5e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/63f528bdc361ad0008ed794a
😎 Deploy Preview https://deploy-preview-138--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karynemayer karynemayer merged commit 5b6f5a0 into develop Feb 21, 2023
@karynemayer karynemayer deleted the bugfix/token-list-reordering branch February 21, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants