-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#499 | ERC1155 inventory updates #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…99-erc1155-inventory-updates
This reverts commit d03eee9.
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…99-erc1155-inventory-updates
ezra-sg
commented
Sep 20, 2023
Merged
…99-erc1155-inventory-updates
10 tasks
donnyquixotic
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499
Description
This PR makes changes to NFTs in order to support ERC1155. Previously, the NFT class was built around the assumption that each NFTClass would have one underlying NFT 'item' which contained most of its relevant information. However with ERC1155, it's more complicated because we have data from potentially many different versions of the same NFT but with different owner data (e.g. owner 1 has 5 of this NFT, owner 2 has 3 of it, etc).
Ultimately this PR simplifies the data structures surrounding NFTs into a single
NFT
class, which is extended byErc721Nft
andErc1155Nft
. The classes can be instantiated directly, but generally the factory functionconstructNft
is more useful; it takes indexer data and generates an NFT from that.This PR also updates the border color for various elements across the site which were previously too light to see, such as the border around NFT tiles and the border between wallet balance rows. It also updates tooltips to have the gradient background from designs
Note: the ability to send 1155s and to view the Owners tab on the NFT detail page will be implemented in #658
Test scenarios
0x....c3c3
Checklist: