Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing wrong usingQR flag #642

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Oct 16, 2023

Fixes #636

Description

This PR fixes the wrong flag usingQR set internally when WalletConnectAuth tries to decide if the user is using an injected provider (Desktop) or is logged from the Mobile throw the QR. If the second is detected the internal flag usingQR is set to true and that makes the class skip checking if the local provider is connected to the correct blockchain. That check was skipped and that generated an error every time the user tried to sign a new transaction.

This error occurred because the account address is now returned in lowercase and that generates an incorrect internal state.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Oct 16, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 7c5ccdc
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/652dc68e3c670b000864fad6
😎 Deploy Preview https://deploy-preview-642--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 7c5ccdc
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/652dc68e552cef00088e574a
😎 Deploy Preview https://deploy-preview-642--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Oct 16, 2023
@Viterbo Viterbo added the 🐛 Bug Something isn't working label Oct 16, 2023
@donnyquixotic donnyquixotic merged commit 67931a9 into develop Oct 23, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 636-walletconnect-is-broken-on-testnet branch October 23, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WalletConnect is broken on Testnet
2 participants