Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the case when the injected provider does not have an account #696

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 28, 2023

Fixes #694

Description

When you run the web app on a desktop browser but you use WalletConnect and read the QR from your mobile, there was a workaround to try to deduce if we are using a locally injected provider (like MetaMask extension) or we are using a remote connection via QR.

There was an error trying to obtaing the current account from the local provider which may not have one.

Test scenarios

  • Get logout from Metamask
    • Disable and enable your Metamask extensio so you will get prompted for the password next interaction
  • go to this link
  • press WalletConnect
  • on your mobile, open Metamask and read the QR
    • you should be able to login with no problems

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 39469af
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65663979db28f90008ca0832
😎 Deploy Preview https://deploy-preview-696--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 39469af
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65663979a98c7c0008309bea
😎 Deploy Preview https://deploy-preview-696--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo marked this pull request as ready for review November 28, 2023 18:53
donnyquixotic
donnyquixotic previously approved these changes Nov 28, 2023
ezra-sg
ezra-sg previously approved these changes Nov 28, 2023
@ezra-sg ezra-sg dismissed stale reviews from donnyquixotic and themself via 39469af November 28, 2023 19:03
@donnyquixotic donnyquixotic merged commit f15c4ad into develop Nov 28, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 694-walletconnect-with-qr-is-broken branch November 28, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WalletConnect with QR is broken
3 participants