-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve on FunctionInterface parameter type handling #104
Labels
✨ Enhancement
Improvements on existing features
Comments
ezra-sg
added
🔬 Needs Refinement
Further information is required
✨ Enhancement
Improvements on existing features
and removed
🐛 Bug
Something isn't working
labels
Oct 9, 2022
ezra-sg
changed the title
Investigate FunctionInterface arg type handling
Investigate FunctionInterface parameter type handling
Oct 10, 2022
ezra-sg
changed the title
Investigate FunctionInterface parameter type handling
Improve on FunctionInterface parameter type handling
Oct 10, 2022
7 tasks
note: verify #86 before closing |
ezra-sg
added a commit
that referenced
this issue
Dec 28, 2022
…rface-parameter-type-handling #104 | Function interface overhaul
#86 seems solved, will close when this work has been merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Presently, only some types of parameters are handled for the Function Interface (accessible via the Contract tab of any
/address
page for a contract). Users attempting to interact with a contract method using args of type other thanuint256
oruint256[x]
(fixed-lengthuint256
array) can result in an error.Acceptance criteria
FunctionInterface.vue
0x
)/demo/inputs
) allowing one to use/test each kind of inputTechnical considerations
Related to #102
Also related to #171, which will partially implement address array handling
Because every type must be parsed differently, there should be an input for each type of solidity data. Types resources:
https://docs.ethers.io/v5/single-page/#/v5/api/utils/abi/
https://blog.logrocket.com/ultimate-guide-data-types-solidity/
solidity data inputs will need to be designed as a part of this ticket. we should attempt to use quasar inputs with as few modifications as possible while still meeting the acceptance criteria
for array inputs, we should see if there is a better pattern for entering several items, though any solution must be compatible with the user copy & pasting a full value (rather than only allowing use to type each one by one, and pressing
enter
to add it to the array)inputs don't necessarily need masking, just validation
Tasks
uint256
->BigNumber
)uint128
anduint256
only vary in valid length) & stub out the expected input componentsBaseFunctionParameterInput
with vmodel and above shared functionalitydemo
route to allow components to be used in isolation, e.g./test/inputs/
FunctionInterface.vue
component to use new inputsThe text was updated successfully, but these errors were encountered: