fix(community-side-navigation): fix submenu not opening when uglified

telus · Jan 14, 2019 · 872b124 · 872b124
1 parent 147d8d2
commit 872b124
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/SideNavigation/SideNavigation.jsx b/packages/SideNavigation/SideNavigation.jsx
@@ -151,7 +151,8 @@ class SideNavigation extends Component {
             {React.Children.map(children, (child, index) => {
               let options = {}
               const id = `TDS-SideNavigation-${index}`
-              if (child.type.name === 'SubMenu') {
+              // check if href is in props to figure out if child is SubMenu or Link
+              if (!('href' in child.props)) {
                 options = {
                   onClick: this.toggleOpen,
                   isOpen: this.checkAccordion(id),

diff --git a/packages/SideNavigation/SubMenu/SubMenu.jsx b/packages/SideNavigation/SubMenu/SubMenu.jsx
@@ -20,14 +20,13 @@ const SubMenu = ({ children, label, onClick, id, isOpen, active }) => {
     subMenuLink: true,
   }
 
+  const onSubMenuClick = () => {
+    onClick(id)
+  }
+
   return (
     <div className={styles.mainDiv}>
-      <button
-        onClick={() => {
-          onClick(id)
-        }}
-        className={active ? styles.active : styles.buttonDefault}
-      >
+      <button onClick={onSubMenuClick} className={active ? styles.active : styles.buttonDefault}>
         <Box vertical={3} inline horizontal={2} dangerouslyAddClassName={styles.space}>
           <ColoredTextProvider>
             <Text size="medium" bold={active}>