Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Controller RBAC and README #21

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Update Controller RBAC and README #21

merged 4 commits into from
Dec 20, 2022

Conversation

ianstanton
Copy link
Member

  • Allow for controller deployment to manage statefulsets
  • Update README with more accurate local dev instructions. In the future we should add some steps to our justfile for creating a kind cluster + local registry. This will simplify local development for us.

sjmiller609
sjmiller609 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which dependency is requiring nightly build?

@ianstanton
Copy link
Member Author

which dependency is requiring nightly build?

@sjmiller609 This is actually no longer necessary (it was last week, not sure what changed to fix this). I'll update these steps.

@sjmiller609
Copy link
Contributor

which dependency is requiring nightly build?

@sjmiller609 This is actually no longer necessary (it was last week, not sure what changed to fix this). I'll update these steps.

Ok cool, something I just noticed in my PR is that the nightly build does more linting auto-corrections, and I think it works ok to use the nightly features on this lint step even though using the stable compiler.

➜  coredb-operator git:(COR-37) rustc --version
rustc 1.65.0 (897e37553 2022-11-02)
➜  coredb-operator git:(COR-37) cargo +nightly fmt
➜  coredb-operator git:(COR-37) $?
zsh: command not found: 0

c1f45be

@ianstanton ianstanton merged commit 1ecd6ac into main Dec 20, 2022
@ianstanton ianstanton deleted the update-controller-permission branch December 20, 2022 16:58
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
@ianstanton
Update Controller RBAC and README (#21)
be511ce
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
@ianstanton
Add reconciler README (#21)
8b7fc86 
* Add some information to root README

* Add README in reconciler dir

* Add some more information about reconciler

* Update example conn string

* Add local dev instructions

Co-authored-by: Ian Stanton <ian@pop-os.localdomain>
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
@mkrisher
[tem-1808] logging (#21)
9a9459f 
* Amends gitignore

* Adds proper logging and stderr and stdout output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@ryw ryw Awaiting requested review from ryw

@ChuckHend ChuckHend Awaiting requested review from ChuckHend

Assignees
No one assigned
Labels
coredb-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianstanton @sjmiller609