Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #218

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Fix typos #218

merged 4 commits into from
Apr 11, 2023

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Apr 9, 2023

Found via codespell -S .git -L crate,bu,vew,astroid,ser,dne,pring

@kianmeng
Fix typos
d6afe43 
Found via `codespell -S .git -L crate,bu,vew,astroid,ser,dne,pring`
@ChuckHend
Copy link
Member

Thank you!

@ChuckHend
Copy link
Member

Could you bump the minor version in ./coredb-cli/Cargo.toml, ./crates/pgmq/Cargo.toml? That should get the CI checks to pass.

The merge conflict in crates/pgmq/src/query.rs looks like its just a comment that has been removed from main.

@kianmeng
Copy link
Contributor Author

The merge conflict in crates/pgmq/src/query.rs looks like its just a comment that has been removed from main.

I don't see any merge conflict?

ChuckHend
ChuckHend approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ChuckHend ChuckHend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@ChuckHend ChuckHend merged commit 7294468 into tembo-io:main Apr 11, 2023
@kianmeng
Copy link
Contributor Author

🎉 🎉 🎉 🎉 🎉

sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
@kianmeng
Fix typos (#218)
a5ce57e
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
@kianmeng
Fix typos (#218)
4a56bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHend ChuckHend ChuckHend approved these changes

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@nhudson nhudson Awaiting requested review from nhudson nhudson is a code owner

@sjmiller609 sjmiller609 Awaiting requested review from sjmiller609

@ryw ryw Awaiting requested review from ryw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kianmeng @ChuckHend