[COR-46] Add service to coredb-operator #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
requested review from
ryw,
ChuckHend and
sjmiller609
as code owners
ChuckHend
approved these changes
Dec 21, 2022
|
@ChuckHend @sjmiller609 JFYI I had a test failure on the first run: https://github.com/CoreDB-io/coredb/actions/runs/3752632886/jobs/6375010728. It succeeded on retry. Okay for now, but let's keep an eye out for flaky tests. |
absolutely, flakey tests are not acceptable. I'll increase the timeout, maybe 30 seconds was a bit optimistic. |
sjmiller609
approved these changes
Dec 21, 2022
Comment on lines
+114
to
+124
| // After the PATCH to CoreDB, we expect a PATCH to Service | ||
| let (request, send) = handle | ||
| .next_request() | ||
| .await | ||
| .expect("Kube API called to PATCH Service"); | ||
| assert_eq!(request.method(), http::Method::PATCH); | ||
| assert_eq!( | ||
| request.uri().to_string(), | ||
| format!("/api/v1/namespaces/testns/services/testdb?&force=true&fieldManager=cntrlr") | ||
| ); | ||
| send.send_response(Response::builder().body(request.into_body()).unwrap()); |
ChuckHend
approved these changes
Dec 21, 2022
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Adds extension install command * Documents the extension install command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service and applicable test. Also added spec values + defaults for
portandimage.Related to: