Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COR-142] Setup initial structure for CLI #51

Merged
merged 10 commits into from
Jan 19, 2023
Merged

[COR-142] Setup initial structure for CLI #51

merged 10 commits into from
Jan 19, 2023

Conversation

sjmiller609
Copy link
Contributor

@sjmiller609 sjmiller609 commented Jan 17, 2023

Ready for review, but will have additions:

  • Testing (integration: call it from outside, make assertions about what happens, Unit: like normal)
  • Implement 'create' subcommand for 'db' resource type
  • publish to homebrew
working-with-limited-functionality.mov

The build header parts

    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `target/debug/coredb-cli create db my-db-name`

will not actually show up in the final, that's just because I have this set locally:

alias coredb='cargo run --'

so it's building on each execution in my test environment

@sjmiller609 sjmiller609 marked this pull request as ready for review January 18, 2023 23:57
@sjmiller609 sjmiller609 changed the title Setup CLI [COR-142] Setup initial structure for CLI Jan 18, 2023
@@ -0,0 +1,18 @@
use super::{ResourceType, SubCommand};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think alternatively, you could add a lib.rs. Then in lib.rs, pub mod everything.rs. Then through the project, including main.rs you can reference all the functions and structs like coredb-cli::commands::{get, create}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will try this

@sjmiller609 sjmiller609 merged commit e1846a1 into main Jan 19, 2023
@sjmiller609 sjmiller609 deleted the cli branch January 19, 2023 00:46
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
* rename to conductor

* rename workflows

* Update conductor-test.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants