[COR-145] Log SQL Statements at Debug Level #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
requested review from
ryw,
ChuckHend and
sjmiller609
as code owners
ChuckHend
reviewed
Feb 6, 2023
| @@ -329,7 +329,7 @@ async fn test_database_error_modes() { | |||
| // we expect a database error | |||
| match queue { | |||
| Err(e) => { | |||
| if let pgmq::errors::PgmqError::DatabaseError { .. } = e { | |||
| if let pgmq::errors::PgmqError::UrlParsingError { .. } = e { | |||
There was a problem hiding this comment.
can you add a test that covers the DatabaseError case? I think it would look something like:
- provided a VALID database connection string, but with either wrong host or password,
pgmq::errors::PgmqError::DatabaseErroris returned.
There was a problem hiding this comment.
Keep the existing test that makes sure DatabaseError happens when its the wrong, but valid, connection string.
Add new test that validates that a poorly formed connection string returns UrlParsingError
ChuckHend
approved these changes
Feb 6, 2023
This was referenced Feb 7, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, sqlx logs SQL statements at info level. This can become very noisy in application logs. This PR allows us to configure the log level by adding
PgConnectOptions.For now, we'll set
options.log_statements(LevelFilter::Debug);and allow for user configurable log level in a follow-up PR.