Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pgx_pgmq read #93

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Fix pgx_pgmq read #93

merged 9 commits into from
Feb 8, 2023

Conversation

ianstanton
Copy link
Member

Read function parameters recently changed. Updating in pgx_pgmq extension.

@ianstanton ianstanton marked this pull request as ready for review February 8, 2023 15:54
@ianstanton
Copy link
Member Author

Need to investigate failures after merging in main (CI was green)

@ianstanton
Copy link
Member Author

pgmq dependency was reverted to 0.4.0

Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would increment the version of pgx_pgmq to 0.0.4 or 0.5.1

@ianstanton
Copy link
Member Author

I would increment the version of pgx_pgmq to 0.0.4 or 0.5.1

Ah, I think we both bumped it to 0.0.3-alpha.1

@@ -1,6 +1,6 @@
[package]
name = "pgx_pgmq"
version = "0.0.3-alpha.1"
version = "0.5.1"
Copy link
Member

@ChuckHend ChuckHend Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to tie these versions (extension and crate) together? I'd expect the crates development to slow over time and the extension to pick up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with 0.0.4 in that case

@ianstanton ianstanton merged commit 79f314c into main Feb 8, 2023
@ianstanton ianstanton deleted the fix-pgx-pgmq-read branch February 8, 2023 16:38
sjmiller609 added a commit that referenced this pull request Dec 5, 2023
* Update adum-tracker.json

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants