Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preload libraries in trunktoml #435

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

EvanHStanton
Copy link
Contributor

No description provided.

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-435.dwcnpr7p8u1tw.amplifyapp.com

@EvanHStanton EvanHStanton marked this pull request as ready for review September 6, 2023 14:59
@@ -7,6 +7,7 @@ description = "auth_delay causes the server to pause briefly before reporting au
homepage = "https://www.postgresql.org"
documentation = "https://www.postgresql.org/docs/current/auth-delay.html"
categories = ["security"]
preload_libraries = ["auth_delay"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvanHStanton if we want to use preload_libraries here we need to make a CLI change

@ianstanton
Copy link
Member

FYI the 'Enable the extension' step won't run on main branch:

- name: Enable the extension
if: ${{ github.ref != 'refs/heads/main' }}

This is designed for cases (like this) in which we know enabling the extension will fail due to shared_preload_libraries not set. For this PR, we want to check the following for each extension test:

  • Does build succeed?
  • Does installation succeed?
    • Does the post installation output instruct the user to set shared_preload_libraries value?
  • If enable fails
    • Does it fail because it requires library loaded? If so, we're good

@ianstanton ianstanton self-requested a review September 6, 2023 17:37
@EvanHStanton EvanHStanton merged commit 0d8debf into main Sep 6, 2023
10 of 19 checks passed
@EvanHStanton EvanHStanton deleted the add_preload_libraries_trunktoml branch September 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants